Add --experimental-issue-pkcs12 flag to enable PKCS12 bundle generation #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
approved
|
/retest |
meyskens
reviewed
Mar 4, 2020
|
That functions actually uses bytes.Compare as I had not spotted 'Equal'! I
chose to have a specific function for it in order to explicitly handle the
'nil' cases...
…On Wed, 4 Mar 2020 at 08:36, Maartje Eyskens ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkg/controller/certificates/sync.go
<#2643 (comment)>
:
> @@ -856,3 +873,16 @@ func setSecretValues(ctx context.Context, crt *cmapi.Certificate, s *corev1.Secr
return nil
}
+
+func bytesEqual(l, r []byte) bool {
Go provides bytes.Equal, any reason we use this function instead?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2643>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABRWP74RBVDJ3ASBHPUFELRFYHIHANCNFSM4LANP5PQ>
.
|
Signed-off-by: James Munnelly <james@munnelly.eu>
|
I've switched to use |
|
/lgtm |
munnerz
added
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a new experimental flag to enable generating PKCS12 bundles in 'target secrets'.
This flag will be replaced with native support for PKCS12 bundles in future, once #2402 has been implemented.
Which issue this PR fixes: part of #586
Special notes for your reviewer:
Release note:
/assign @meyskens
/cc @JoshVanL